update README.md, fix make test, add circle.yml
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tiancaiamao
commented
Nov 7, 2018
tiancaiamao
commented
- Remove go.mod so the TiDB and parser repo won't be a circle
- Add circle.yml so this repo will run CI later
- Add README.md about "How to update parser for TiDB"
|
/cc @morgo |
This was referenced Nov 7, 2018
kennytm
reviewed
Nov 7, 2018
lysu
reviewed
Nov 7, 2018
Makefile
Outdated
| GO111MODULE=on go test ./... | ||
| mv go.mod go.mod1 | ||
| mv go.sum go.sum1 |
There was a problem hiding this comment.
how about make test failured situation? it seem re-run make test will meet error.
|
@CaitinChen PTAL |
lysu
reviewed
Nov 8, 2018
tiancaiamao
force-pushed
the
update-parser
branch
from
afe7263 to
aa84a57
Compare
CaitinChen
reviewed
Nov 8, 2018
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
Co-Authored-By: tiancaiamao <tiancaiamao@gmail.com>
kennytm
reviewed
Nov 8, 2018
zimulala
pushed a commit
to zimulala/parser
that referenced
this pull request
Nov 8, 2018
tiancaiamao
added a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.