parser: add DROP ROLE support
#237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2019 18:45
imtbkcat
changed the title
DROP ROLE supportDROP ROLE support
zz-jason
reviewed
Mar 9, 2019
| @@ -2429,19 +2429,31 @@ DropViewStmt: | |||
| DropUserStmt: | |||
| "DROP" "USER" UsernameList | |||
| { | |||
| $$ = &ast.DropUserStmt{IfExists: false, UserList: $3.([]*auth.UserIdentity)} | |||
| $$ = &ast.DropUserStmt{IsDropRole: false, IfExists: false, UserList: $3.([]*auth.UserIdentity)} | |||
There was a problem hiding this comment.
how about using a new DropRoleStmt?
There was a problem hiding this comment.
actually there is no difference between DROP USER and DROP ROLE. I think IsDropRole can be removed.
|
LGTM |
tiancaiamao
approved these changes
Mar 12, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
add
DROP ROLEfunction for parser and executor.What is changed and how it works?
Role is same as user, is store in
mysql.usertable. We do same action asDROP USERwhen we need to drop a role. Also, as we has added some system table for RBAC, likemysql.role_edgesandmysql.default_role. We have to delete information from these tables when executeDROP ROLEtidb pr: pingcap/tidb#9616
Check List
Tests
Code changes
Side effects