-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add table option: pre_split_regions #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
reviewed
Apr 12, 2019
Co-Authored-By: crazycs520 <crazycs520@gmail.com>
Co-Authored-By: crazycs520 <crazycs520@gmail.com>
kennytm
changed the title
*: add table option: pre_split_resions
*: add table option: pre_split_regions
Apr 12, 2019
kennytm
reviewed
Apr 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please update parser.go
and sign the CLA so the tests can pass.
winkyao
reviewed
Apr 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kennytm
approved these changes
Apr 15, 2019
crazycs520
added a commit
to crazycs520/parser
that referenced
this pull request
Jun 19, 2019
winkyao
pushed a commit
that referenced
this pull request
Jun 19, 2019
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* *: add table option: pre_split_resions * refine code * add PreSplitRegions in tableInfo * Update misc.go Co-Authored-By: crazycs520 <crazycs520@gmail.com> * Update parser.y Co-Authored-By: crazycs520 <crazycs520@gmail.com> * address comment * refine comment
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
* *: add table option: pre_split_resions * refine code * add PreSplitRegions in tableInfo * Update misc.go Co-Authored-By: crazycs520 <crazycs520@gmail.com> * Update parser.y Co-Authored-By: crazycs520 <crazycs520@gmail.com> * address comment * refine comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This is for pre-split region when create table with shard_row_id_bits.
What is changed and how it works?
Check List
Tests
Code changes
Side effects