Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add table option: pre_split_regions #287

Merged
merged 8 commits into from
Apr 15, 2019
Merged

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

This is for pre-split region when create table with shard_row_id_bits.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2019

CLA assistant check
All committers have signed the CLA.

misc.go Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
kennytm and others added 4 commits April 12, 2019 19:21
Co-Authored-By: crazycs520 <crazycs520@gmail.com>
Co-Authored-By: crazycs520 <crazycs520@gmail.com>
@kennytm kennytm changed the title *: add table option: pre_split_resions *: add table option: pre_split_regions Apr 12, 2019
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please update parser.go and sign the CLA so the tests can pass.

@kennytm kennytm added the status/LGT1 LGT1 label Apr 12, 2019
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Apr 15, 2019
@kennytm kennytm merged commit b52af6e into pingcap:master Apr 15, 2019
crazycs520 added a commit to crazycs520/parser that referenced this pull request Jun 19, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* *: add table option: pre_split_resions

* refine code

* add PreSplitRegions in tableInfo

* Update misc.go

Co-Authored-By: crazycs520 <crazycs520@gmail.com>

* Update parser.y

Co-Authored-By: crazycs520 <crazycs520@gmail.com>

* address comment

* refine comment
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
* *: add table option: pre_split_resions

* refine code

* add PreSplitRegions in tableInfo

* Update misc.go

Co-Authored-By: crazycs520 <crazycs520@gmail.com>

* Update parser.y

Co-Authored-By: crazycs520 <crazycs520@gmail.com>

* address comment

* refine comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants