Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add where for show table region syntax #398

Merged
merged 11 commits into from
Sep 3, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

  • Add where for show table region syntax

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@crazycs520 crazycs520 added the type/enhancement New feature or request label Jul 25, 2019
@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   70.17%   70.15%   -0.02%     
==========================================
  Files          32       32              
  Lines        7437     7439       +2     
==========================================
  Hits         5219     5219              
- Misses       1703     1704       +1     
- Partials      515      516       +1
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/dml.go 73.55% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57e1f3b...35fe579. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   71.79%   71.75%   -0.04%     
==========================================
  Files          32       32              
  Lines        7800     7789      -11     
==========================================
- Hits         5600     5589      -11     
  Misses       1673     1673              
  Partials      527      527
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/dml.go 73.56% <0%> (-0.12%) ⬇️
ast/ddl.go 80.53% <0%> (-0.04%) ⬇️
mysql/const.go 25.27% <0%> (ø) ⬆️
misc.go 96.49% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 275a827...1eae5b0. Read the comment docs.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jul 27, 2019

What is this PR used for?

@crazycs520
Copy link
Contributor Author

@winkyao This use for support SQL like show table t regions where scattering=1;

parser.y Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

parser.y Outdated Show resolved Hide resolved
@crazycs520
Copy link
Contributor Author

/rebuild

@crazycs520
Copy link
Contributor Author

@kennytm PTAL

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants