Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser : add support for octet_length function #401

Merged
merged 2 commits into from
Jul 26, 2019
Merged

parser : add support for octet_length function #401

merged 2 commits into from
Jul 26, 2019

Conversation

gaoxingliang
Copy link
Contributor

@gaoxingliang gaoxingliang commented Jul 25, 2019

What problem does this PR solve?

Add support for octet_length and Fix pingcap/tidb#11195

What is changed and how it works?

add a ast node

Check List

Tests

  • Unit test added.

The PR in tidb is : pingcap/tidb#11451

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #401 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          32       32           
  Lines        7448     7448           
=======================================
  Hits         5230     5230           
  Misses       1703     1703           
  Partials      515      515
Impacted Files Coverage Δ
ast/functions.go 74.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a8bfd...1b0fe23. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #401 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          32       32           
  Lines        7448     7448           
=======================================
  Hits         5230     5230           
  Misses       1703     1703           
  Partials      515      515
Impacted Files Coverage Δ
ast/functions.go 74.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a8bfd...59148ea. Read the comment docs.

Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PTAL @SunRunAway

@kennytm kennytm added the status/LGT1 LGT1 label Jul 25, 2019
ast/functions.go Outdated Show resolved Hide resolved
@zz-jason zz-jason requested a review from SunRunAway July 26, 2019 01:55
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway merged commit ca2f45b into pingcap:master Jul 26, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function OCTET_LENGTH is not implemented but the documentation says yes.
4 participants