Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for STORAGE table option #407

Merged
merged 3 commits into from
Jul 30, 2019
Merged

add support for STORAGE table option #407

merged 3 commits into from
Jul 30, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jul 29, 2019

What problem does this PR solve?

Add support for STORAGE table option.

Issue: #403

MySQL syntax:

table_option:
  | TABLESPACE tablespace_name 
  | STORAGE {DISK|MEMORY}
...

Check List

Tests

  • Unit test

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 29, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   70.23%   70.25%   +0.01%     
==========================================
  Files          32       32              
  Lines        7452     7456       +4     
==========================================
+ Hits         5234     5238       +4     
  Misses       1703     1703              
  Partials      515      515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 78.01% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1b3d...c99d2ff. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 29, 2019 •
edited
Loading

Codecov Report

Merging #407 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   70.23%   70.24%   +0.01%     
==========================================
  Files          32       32              
  Lines        7452     7455       +3     
==========================================
+ Hits         5234     5237       +3     
  Misses       1703     1703              
  Partials      515      515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 77.99% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d1b3d...a2712ef. Read the comment docs.

@zier-one zier-one self-assigned this Jul 30, 2019
@zier-one zier-one mentioned this pull request Jul 30, 2019
Closed
58 tasks
@zier-one
Copy link
Contributor

thanks for your contribution!

sign the agreement please @leiysky

zier-one
zier-one reviewed Jul 30, 2019
View reviewed changes
parser.y Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
@zier-one zier-one requested a review from kennytm July 30, 2019 02:27
@zier-one
Copy link
Contributor

@kennytm PTAL

leiysky
leiysky commented Jul 30, 2019
View reviewed changes
parser_test.go Outdated Show resolved Hide resolved
leiysky
leiysky commented Jul 30, 2019
View reviewed changes
parser_test.go Outdated Show resolved Hide resolved
@leiysky
Copy link
Contributor Author

leiysky commented Jul 30, 2019

@leoppro Resolved

@kennytm

This comment has been minimized.

Sign in to view
kennytm
kennytm approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm merged commit 2414ee7 into pingcap:master Jul 30, 2019
@zier-one zier-one added the status/LGT2 LGT2 label Jul 30, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@leiysky @kennytm
add support for STORAGE table option (pingcap#407)
39a6ac0 
* add support for STORAGE table option

* Apply suggestions from code review

Co-Authored-By: leoppro <i@leop.pro>

* add warning when parsing STORAGE
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@leiysky @kennytm
add support for STORAGE table option (pingcap#407)
d731bc3 
* add support for STORAGE table option

* Apply suggestions from code review

Co-Authored-By: leoppro <i@leop.pro>

* add warning when parsing STORAGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@kennytm kennytm kennytm approved these changes

Assignees

@zier-one zier-one

Labels
contribution status/LGT2 LGT2 type/compatibility type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiysky @CLAassistant @zier-one @kennytm