Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for STATS_SAMPLE_PAGES #414

Merged
merged 2 commits into from
Jul 30, 2019
Merged

add support for STATS_SAMPLE_PAGES #414

merged 2 commits into from
Jul 30, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jul 30, 2019

What problem does this PR solve?

MySQL syntax:

create_table_option:
...
        | STATS_SAMPLE_PAGES_SYM opt_equal ulong_num
        | STATS_SAMPLE_PAGES_SYM opt_equal DEFAULT_SYM

Issue: #404

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #414 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   70.24%   70.27%   +0.02%     
==========================================
  Files          32       32              
  Lines        7455     7462       +7     
==========================================
+ Hits         5237     5244       +7     
  Misses       1703     1703              
  Partials      515      515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 78.1% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2414ee7...053051b. Read the comment docs.

@zier-one zier-one self-assigned this Jul 30, 2019
@zier-one zier-one self-requested a review July 30, 2019 04:58
zier-one
zier-one reviewed Jul 30, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@kennytm PTAL

@zier-one zier-one requested a review from kennytm July 30, 2019 05:00
@zier-one zier-one mentioned this pull request Jul 30, 2019
Closed
58 tasks
kennytm
kennytm reviewed Jul 30, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Jul 30, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PTAL again @leoppro

@kennytm kennytm added the status/LGT1 LGT1 label Jul 30, 2019
zier-one
zier-one approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit d34bdb6 into pingcap:master Jul 30, 2019
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jul 30, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@leiysky
add support for STATS_SAMPLE_PAGES (pingcap#414)
13b92b9
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@leiysky
add support for STATS_SAMPLE_PAGES (pingcap#414)
99296c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

Assignees

@zier-one zier-one

Labels
contribution status/LGT2 LGT2 type/compatibility type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leiysky @kennytm @zier-one