Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for SECONDARY_ENGINE #418

Merged
merged 5 commits into from
Aug 3, 2019
Merged

add support for SECONDARY_ENGINE #418

merged 5 commits into from
Aug 3, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Jul 30, 2019

What problem does this PR solve?

MySQL syntax:

create_table_option:
        ......
        | SECONDARY_ENGINE_SYM opt_equal NULL_SYM
        | SECONDARY_ENGINE_SYM opt_equal ident_or_text

Issue: #405

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #418 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #418      +/-   ##
=========================================
+ Coverage   70.66%   70.7%   +0.03%     
=========================================
  Files          32      32              
  Lines        7436    7444       +8     
=========================================
+ Hits         5255    5263       +8     
  Misses       1666    1666              
  Partials      515     515
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 78.29% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92cb39...bc34a67. Read the comment docs.

kennytm
kennytm reviewed Jul 31, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
leiysky
leiysky commented Jul 31, 2019
View reviewed changes
ast/ddl.go Show resolved Hide resolved
leiysky
leiysky commented Jul 31, 2019
View reviewed changes
parser.y Outdated Show resolved Hide resolved
leiysky
leiysky commented Jul 31, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
@zier-one zier-one self-assigned this Jul 31, 2019
@zier-one
Copy link
Contributor

the integration test is failed, I'm working on it

@zier-one
Copy link
Contributor

zier-one commented Aug 1, 2019

blocked by pingcap/tidb#11553

@kennytm
Copy link
Contributor

kennytm commented Aug 1, 2019

@leoppro The integration test isn't required here so it isn't really blocking any PRs.

@zier-one
Copy link
Contributor

zier-one commented Aug 1, 2019

@leoppro The integration test isn't required here so it isn't really blocking any PRs.

fine LGTM

@zier-one zier-one added the status/LGT1 LGT1 label Aug 1, 2019
@zier-one zier-one mentioned this pull request Aug 1, 2019
Closed
58 tasks
@zier-one
Copy link
Contributor

zier-one commented Aug 1, 2019

@kennytm PTAL

tangenta
tangenta reviewed Aug 2, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
@leiysky
Copy link
Contributor Author

leiysky commented Aug 2, 2019

@leoppro PTAL

tangenta
tangenta approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 3, 2019
@zier-one zier-one merged commit d9c1156 into pingcap:master Aug 3, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@leiysky
add support for SECONDARY_ENGINE (pingcap#418)
62c183b
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@leiysky
add support for SECONDARY_ENGINE (pingcap#418)
f4a4ca4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

@tangenta tangenta tangenta approved these changes

Assignees

@zier-one zier-one

Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leiysky @zier-one @kennytm @tangenta