Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for RTREE index #433

Merged
merged 2 commits into from
Aug 5, 2019
Merged

add support for RTREE index #433

merged 2 commits into from
Aug 5, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Aug 4, 2019

What problem does this PR solve?

Add support for RTREE index.

What is changed and how it works?

MySQL syntax:

index_type:
          BTREE_SYM { $$= HA_KEY_ALG_BTREE; }
        | RTREE_SYM { $$= HA_KEY_ALG_RTREE; }
        | HASH_SYM  { $$= HA_KEY_ALG_HASH; }
        ;

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

Merging #433 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   70.83%   70.84%   +<.01%     
==========================================
  Files          32       32              
  Lines        7499     7501       +2     
==========================================
+ Hits         5312     5314       +2     
  Misses       1674     1674              
  Partials      513      513
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
model/model.go 48.93% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db5c16...3d22709. Read the comment docs.

@zier-one
Copy link
Contributor

zier-one commented Aug 5, 2019

LGTM

@zier-one
Copy link
Contributor

zier-one commented Aug 5, 2019

@kennytm PTAL

@tangenta
Copy link
Contributor

tangenta commented Aug 5, 2019

LGTM

@zier-one zier-one added status/LGT2 LGT2 and removed PTAL labels Aug 5, 2019
@zier-one zier-one merged commit 34f6018 into pingcap:master Aug 5, 2019
@leiysky leiysky deleted the fix/rtree branch August 5, 2019 03:34
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants