-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: fix IF NOT EXISTS
support for MariaDB ADD PARTITION
syntax
#455
Conversation
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 32 32
Lines 7522 7522
=====================================
Hits 5341 5341
Misses 1665 1665
Partials 516 516
Continue to review full report at Codecov.
|
@csuzhangxc PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pingcap#455) * parser: fix support for MariaDB syntax * ADD parser.go
pingcap#455) * parser: fix support for MariaDB syntax * ADD parser.go
What problem does this PR solve?
#337 support
IF NOT EXISTS
option forADD PARTITION
syntax in MaraiDB 10.0.2+, but not complete. the same support forADD PARTITION PARTITIONS NUM
syntax is missing.For example, we have a table defined as follows:
in MaraiDB 10.0.2+, the following statement is ok :
while for now, this sql failed in parser:
What is changed and how it works?
Add
IfNotExists
option for the corresponding branch forADD PARTITION
syntax in parser.y.Check List
Tests
Code changes
N/A
Side effects
N/A