-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: fix CHARACTER VARYING syntax #465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 32 32
Lines 7534 7534
=======================================
Hits 5356 5356
Misses 1662 1662
Partials 516 516
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 32 32
Lines 7534 7534
=======================================
Hits 5356 5356
Misses 1662 1662
Partials 516 516
Continue to review full report at Codecov.
|
LGTM |
@tangenta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lauhg Thank you for your contribution! Please address the comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix compatibility problem about
CHARACTER VARYING
syntaxIssue: #410
MySQL Syntax:
type: ... | CHAR_SYM field_length opt_charset_with_opt_binary | CHAR_SYM opt_charset_with_opt_binary | nchar field_length opt_bin_mod | nchar opt_bin_mod | varchar field_length opt_charset_with_opt_binary | nvarchar field_length opt_bin_mod
Bad SQL Case:
Check List
Tests