Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: Support keyword FIELDS in ALTER TABLE PARTITION BY syntax #471

Merged
merged 6 commits into from
Aug 15, 2019

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

To #464 , support keyword FIELDS in ALTER TABLE PARTITION BY syntax

What is changed and how it works?

  1. Use FieldsOrColumns instead of COLUMNS in PartitionMethod
  2. Add related tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

Related changes

N / A

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #471   +/-   ##
=======================================
  Coverage   71.12%   71.12%           
=======================================
  Files          32       32           
  Lines        7542     7542           
=======================================
  Hits         5364     5364           
  Misses       1662     1662           
  Partials      516      516
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f07200...392c553. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #471 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   71.24%   71.19%   -0.05%     
==========================================
  Files          32       32              
  Lines        7594     7560      -34     
==========================================
- Hits         5410     5382      -28     
+ Misses       1665     1662       -3     
+ Partials      519      516       -3
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
ast/ddl.go 79.02% <0%> (-0.08%) ⬇️
misc.go 96.42% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 315a7ae...284fb43. Read the comment docs.

parser_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Aug 14, 2019
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 15, 2019
@zier-one
Copy link
Contributor

LGTM

@zier-one
Copy link
Contributor

please resolve the conflict

@zier-one zier-one merged commit 1ba2994 into pingcap:master Aug 15, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants