Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix LONG syntax #473

Merged
merged 3 commits into from
Aug 14, 2019
Merged

parser: fix LONG syntax #473

merged 3 commits into from
Aug 14, 2019

Conversation

lauhg
Copy link
Contributor

@lauhg lauhg commented Aug 14, 2019

What problem does this PR solve?

Fix compatibility problem about LONG syntax

Issue: #470

MySQL Syntax:

type:
...
  | LONG_SYM opt_charset_with_opt_binary
  | LONG_SYM varchar opt_charset_with_opt_binary

Bad SQL Case:

create table t (a long)
create table t (a long varchar)
create table t (a mediumtext, b long varchar, c long)

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Aug 14, 2019 •
edited
Loading

Codecov Report

Merging #473 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #473   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files          32       32           
  Lines        7560     7560           
=======================================
  Hits         5382     5382           
  Misses       1662     1662           
  Partials      516      516
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d2d68...776e5fe. Read the comment docs.

zier-one
zier-one reviewed Aug 14, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM
@tangenta PTAL

parser_test.go Outdated Show resolved Hide resolved
tangenta
tangenta previously approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lauhg and others added 3 commits August 14, 2019 18:22
@kennytm kennytm added the status/LGT2 LGT2 label Aug 14, 2019
@kennytm kennytm merged commit 6c5514f into pingcap:master Aug 14, 2019
@zier-one zier-one mentioned this pull request Aug 15, 2019
Closed
58 tasks
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@lauhg @kennytm
parser: fix LONG syntax (pingcap#473)
bf7aeb7 
* parser: fix LONG syntax

* address comment

Co-Authored-By: leoppro <i@leop.pro>

* resolve conflicts
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@lauhg @kennytm
parser: fix LONG syntax (pingcap#473)
3244e0b 
* parser: fix LONG syntax

* address comment

Co-Authored-By: leoppro <i@leop.pro>

* resolve conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@kennytm kennytm kennytm approved these changes

@tangenta tangenta tangenta left review comments

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lauhg @kennytm @tangenta @zier-one @you06