Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keyword SERIAL #481

Merged
merged 11 commits into from
Aug 21, 2019
Merged

Support keyword SERIAL #481

merged 11 commits into from
Aug 21, 2019

Conversation

spongedu
Copy link
Contributor

What problem does this PR solve?

for #467 , support keyword SERIAL.

What is changed and how it works?

  1. Support SERIAL as a Numeric Type in ColumnDef
  2. Support SERIAL DEFAULT VALUE as an ColumnOption
  3. Add related tests

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

N / A

Side effects

N / A

@spongedu
Copy link
Contributor Author

it's interesting that the Verify parser.go is up-to-date stage in tests is not consistent with the fmt stage. The tests will fail anyway...

@spongedu
Copy link
Contributor Author

I think we should add a fmt command in Verify parser.go is up-to-date stage in the ci test base

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the status/LGT1 LGT1 label Aug 16, 2019
@spongedu
Copy link
Contributor Author

@leoppro PTAL :)

parser_test.go Show resolved Hide resolved
parser_test.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #481 into master will decrease coverage by 0.07%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   71.59%   71.51%   -0.08%     
==========================================
  Files          32       32              
  Lines        7723     7689      -34     
==========================================
- Hits         5529     5499      -30     
+ Misses       1670     1668       -2     
+ Partials      524      522       -2
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 80% <90.47%> (-0.18%) ⬇️
ast/misc.go 74.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd016b8...9c60c1c. Read the comment docs.

@zier-one
Copy link
Contributor

LGTM please resolve conflicts
@spongedu

@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 21, 2019
@kennytm kennytm merged commit e2490d9 into pingcap:master Aug 21, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
* Support keyword `SERIAL`

* Fix fmt

* make fmt happy

* execute gofmt after `make parser`

* revert modification on Makefile
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
* Support keyword `SERIAL`

* Fix fmt

* make fmt happy

* execute gofmt after `make parser`

* revert modification on Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants