Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support COLUMN_FORMAT syntax. #482

Merged
merged 4 commits into from
Aug 19, 2019
Merged

Support COLUMN_FORMAT syntax. #482

merged 4 commits into from
Aug 19, 2019

Conversation

doggeral
Copy link
Contributor

What problem does this PR solve?

To support the COLUMN_FORMAT syntex.
#476

What is changed and how it works?

Add the COLUMN_FORMAT support.

Check List

  • Unit test

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #482 into master will decrease coverage by 0.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #482      +/-   ##
=========================================
- Coverage   71.48%   71.2%   -0.28%     
=========================================
  Files          32      32              
  Lines        7672    7563     -109     
=========================================
- Hits         5484    5385      -99     
+ Misses       1667    1662       -5     
+ Partials      521     516       -5
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️
misc.go 96.42% <ø> (ø) ⬆️
ast/ddl.go 79.06% <100%> (-0.85%) ⬇️
ast/misc.go 74.05% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f558842...80b3d49. Read the comment docs.

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doggeral Thank you for your contribution! Would you please address the comments below?

parser.y Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the status/LGT1 LGT1 label Aug 16, 2019
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

parser.y Outdated
{
$$ = "DEFAULT"
}
| "FIXED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please indent this line.

parser.y Outdated Show resolved Hide resolved
parser.y Outdated Show resolved Hide resolved
@tangenta tangenta added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 16, 2019
@doggeral
Copy link
Contributor Author

Resolved the conflict.

@zier-one zier-one merged commit b57ca26 into pingcap:master Aug 19, 2019
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants