-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support COLUMN_FORMAT syntax. #482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
=========================================
- Coverage 71.48% 71.2% -0.28%
=========================================
Files 32 32
Lines 7672 7563 -109
=========================================
- Hits 5484 5385 -99
+ Misses 1667 1662 -5
+ Partials 521 516 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doggeral Thank you for your contribution! Would you please address the comments below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
parser.y
Outdated
{ | ||
$$ = "DEFAULT" | ||
} | ||
| "FIXED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indent this line.
Resolved the conflict. |
What problem does this PR solve?
To support the COLUMN_FORMAT syntex.
#476
What is changed and how it works?
Add the COLUMN_FORMAT support.
Check List