Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add support for TABLE_CHECKSUM #488

Merged
merged 2 commits into from
Aug 16, 2019
Merged

fix: add support for TABLE_CHECKSUM #488

merged 2 commits into from
Aug 16, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Aug 15, 2019 •
edited
Loading

What problem does this PR solve?

Add support for TABLE_CHECKSUM. #468

What is changed and how it works?

MySQL syntax:

create_table_option:
    ......
    | TABLE_CHECKSUM_SYM opt_equal ulong_num

Check List

Tests

  • Unit test

zier-one
zier-one reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added the status/LGT1 LGT1 label Aug 16, 2019
@codecov
Copy link

codecov bot commented Aug 16, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b5eed07). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage          ?   71.48%           
=========================================
  Files             ?       32           
  Lines             ?     7672           
  Branches          ?        0           
=========================================
  Hits              ?     5484           
  Misses            ?     1667           
  Partials          ?      521
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø)
misc.go 96.42% <ø> (ø)
ast/ddl.go 79.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5eed07...6d4f7d4. Read the comment docs.

tangenta
tangenta reviewed Aug 16, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one mentioned this pull request Aug 16, 2019
Closed
58 tasks
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 16, 2019
@tangenta tangenta merged commit 344a139 into pingcap:master Aug 16, 2019
@leiysky leiysky deleted the fix/table-checksum branch August 17, 2019 00:49
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@leiysky
fix: add support for TABLE_CHECKSUM (pingcap#488)
89542af
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@leiysky
fix: add support for TABLE_CHECKSUM (pingcap#488)
8771162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leiysky @tangenta @zier-one