-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: support SQL_TSI_*
#495
Conversation
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 71.48% 71.48%
=======================================
Files 32 32
Lines 7672 7672
=======================================
Hits 5484 5484
Misses 1667 1667
Partials 521 521
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ichn-hu Thanks for your contribution! Could you resolve the conflicts please? |
Yes of course, will do it right away, thanks for recognizing my contribution. |
What problem does this PR solve?
Fix #480 , adding
SQL_TSI_*
support toTimestampUnit
, make it compatible with MySQLWhat is changed and how it works?
Changed the yacc file to add these additional tokens, and replicated the original TimestampUnit interval node in the AST, since
SQL_STI_*
is essentially an alias to these interval tokens.Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes
N/A