Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: fix the panics of testing the TiDB PR #8017 #5

Closed
wants to merge 1 commit into from
Closed

ast: fix the panics of testing the TiDB PR #8017 #5

wants to merge 1 commit into from

Conversation

dbjoa
Copy link
Contributor

@dbjoa dbjoa commented Oct 31, 2018

The TiDB PR #8017 is depend on this PR.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@eurekaka @winoros PTAL

@eurekaka
Copy link
Contributor

eurekaka commented Nov 2, 2018

This is not needed anymore? I see pingcap/tidb#8107 has updated unit test.

@dbjoa
Copy link
Contributor Author

dbjoa commented Nov 2, 2018

I think so. I'll close it.

@dbjoa dbjoa closed this Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants