Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: add stmtType to ast.Prepared to record metric (#487) #510

Merged
merged 1 commit into from
Aug 27, 2019
Merged

ast: add stmtType to ast.Prepared to record metric (#487) #510

merged 1 commit into from
Aug 27, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Aug 21, 2019 •
edited
Loading

cherry-pick #487 to 3.0

This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@1a31cab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             release-3.0   #510   +/-   ##
============================================
  Coverage               ?    51%           
============================================
  Files                  ?     31           
  Lines                  ?   6842           
  Branches               ?      0           
============================================
  Hits                   ?   3490           
  Misses                 ?   3003           
  Partials               ?    349
Impacted Files Coverage Δ
ast/misc.go 17.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a31cab...d39bf6a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 21, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@1a31cab). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             release-3.0   #510   +/-   ##
============================================
  Coverage               ?    51%           
============================================
  Files                  ?     31           
  Lines                  ?   6842           
  Branches               ?      0           
============================================
  Hits                   ?   3490           
  Misses                 ?   3003           
  Partials               ?    349
Impacted Files Coverage Δ
ast/misc.go 17.92% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a31cab...d39bf6a. Read the comment docs.

jackysp
jackysp reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao merged commit 7cd3022 into pingcap:release-3.0 Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/cherry-pick-for-release-3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lysu @tiancaiamao @jackysp