-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CREATE INDEX .. VISIBLE/INVISIBLE syntax #518
Fix CREATE INDEX .. VISIBLE/INVISIBLE syntax #518
Conversation
…reate_index_visible_invisible # Conflicts: # parser.go # parser.y
…reate_index_visible_invisible # Conflicts: # parser.go
…reate_index_visible_invisible
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 71.67% 71.68% +0.01%
==========================================
Files 32 32
Lines 7752 7756 +4
==========================================
+ Hits 5556 5560 +4
Misses 1671 1671
Partials 525 525
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolve conflicts please |
…reate_index_visible_invisible # Conflicts: # parser.go
What problem does this PR solve?
Fix CREATE INDEX .. VISIBLE/INVISIBLE syntax
Issue: #478
MySQL Syntax:
Bad SQL Case:
Check List
Tests
PS:
Since the default option is visible,
VISIBLE
won't be restored.