Parser: support with parser ident #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
==========================================
- Coverage 71.74% 71.74% -0.01%
==========================================
Files 32 32
Lines 7772 7779 +7
==========================================
+ Hits 5576 5581 +5
- Misses 1671 1672 +1
- Partials 525 526 +1
Continue to review full report at Codecov.
|
kennytm
reviewed
Aug 26, 2019
| @@ -1335,7 +1346,7 @@ func (n *CreateIndexStmt) Restore(ctx *RestoreCtx) error { | |||
| } | |||
| ctx.WritePlain(")") | |||
|
|
|||
| if n.IndexOption.Tp != model.IndexTypeInvalid || n.IndexOption.KeyBlockSize > 0 || n.IndexOption.Comment != "" || n.IndexOption.Visibility != IndexVisibilityDefault { | |||
| if n.IndexOption.Tp != model.IndexTypeInvalid || n.IndexOption.KeyBlockSize > 0 || n.IndexOption.Comment != "" || len(n.IndexOption.ParserName.O) > 0 || n.IndexOption.Visibility != IndexVisibilityDefault { | |||
There was a problem hiding this comment.
This condition is getting too long. Could you refactor this into a method of IndexOption?
There was a problem hiding this comment.
I tried a lot of ways, but they didn't work well because there were so many influences, such as creating table.
zier-one
reviewed
Aug 27, 2019
kennytm
approved these changes
Aug 27, 2019
58 tasks
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
lyonzhi
pushed a commit
to lyonzhi/parser
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix compatibility problem about keyword WITH PARSER parser_name
Issue: #507
MySQL Syntax:
index_option:
...
| WITH PARSER parser_name
Bad SQL Case:
create fulltext index idx on t (a, b) with parser ident
create fulltext index idx on t (a, b) with parser ident comment 'string'
create fulltext index idx on t (a, b) comment 'string' with parser ident
create fulltext index idx on t (a, b) with parser ident lock default
Check List
Tests