-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parser: fix alter_stmt order by syntax #526
Conversation
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 71.77% 71.76% -0.01%
==========================================
Files 32 32
Lines 7787 7800 +13
==========================================
+ Hits 5589 5598 +9
- Misses 1672 1674 +2
- Partials 526 528 +2
Continue to review full report at Codecov.
|
# Conflicts: # parser.go
# Conflicts: # parser.go
# Conflicts: # parser.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tangenta PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix ORDER BY syntax. Issue: #499
MySQL Syntax:
Bad SQL Case:
Check List
Tests
Code changes
Related changes