-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser: support storage engine and VALUE IN MAXVALUE #542
Conversation
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=======================================
Coverage 71.77% 71.77%
=======================================
Files 32 32
Lines 7802 7802
=======================================
Hits 5600 5600
Misses 1674 1674
Partials 528 528
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=======================================
Coverage 71.76% 71.76%
=======================================
Files 32 32
Lines 7813 7813
=======================================
Hits 5607 5607
Misses 1676 1676
Partials 530 530
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please resolve the conflicts? You need to run make parser
after updating parser.y.
Co-Authored-By: leoppro <i@leop.pro>
098c6a7
to
48b7e9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
fix issues: #500
MySQL Syntax:
ALTER TABLE ..., ADD PARTITION ( PARTITION ... STORAGE ENGINE text_string ...)
Bad Case
Check List
Tests