Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support database name for optimizer hint #586

Merged
merged 2 commits into from
Oct 25, 2019
Merged

parser: support database name for optimizer hint #586

merged 2 commits into from
Oct 25, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 25, 2019

What problem does this PR solve?

Support database name in optimizer hint like select /*+ USE_INDEX(test.t, c_d_e) */ * from t.

For pingcap/tidb#12932

What is changed and how it works?

Parse the database name hint and put it into HintTable.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx requested review from foreyes, lzmhhh123 and a team October 25, 2019 07:29
@ghost ghost requested review from tangenta and removed request for a team October 25, 2019 07:29
@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited
Loading

Codecov Report

Merging #586 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   71.84%   71.85%   +0.01%     
==========================================
  Files          32       32              
  Lines        7896     7899       +3     
==========================================
+ Hits         5673     5676       +3     
  Misses       1684     1684              
  Partials      539      539
Impacted Files Coverage Δ
parser.go 70.37% <ø> (ø) ⬆️
ast/misc.go 74.67% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3ba4c0...7b7b1b3. Read the comment docs.

lzmhhh123
lzmhhh123 reviewed Oct 25, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 LGT1 label Oct 25, 2019
@tiancaiamao
Copy link
Collaborator

LGTM

@tiancaiamao tiancaiamao added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Oct 25, 2019
@alivxxx alivxxx merged commit f8adf16 into pingcap:master Oct 25, 2019
@alivxxx alivxxx deleted the hint-db-name branch October 25, 2019 08:29
@tangenta tangenta mentioned this pull request Apr 14, 2020
Merged
@tangenta tangenta mentioned this pull request Apr 28, 2020
Closed
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@alivxxx
parser: support database name for optimizer hint (pingcap#586)
166bc02
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@alivxxx
parser: support database name for optimizer hint (pingcap#586)
fad2389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@foreyes foreyes Awaiting requested review from foreyes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alivxxx @tiancaiamao @lzmhhh123