Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (#581) #665

Merged
merged 1 commit into from
Dec 9, 2019
Merged

remove GrantPriv from AllGlobalPrivs/AllDBPrivs/AllTablePrivs (#581) #665

merged 1 commit into from
Dec 9, 2019

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Dec 6, 2019

What problem does this PR solve?

cherry-pick #581

@imtbkcat imtbkcat mentioned this pull request Dec 6, 2019
Merged
kennytm
kennytm reviewed Dec 7, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label Dec 7, 2019
@tiancaiamao
Copy link
Collaborator

LGTM
This one should be merged together with pingcap/tidb#13943

@jackysp jackysp merged commit 9504797 into pingcap:release-3.0 Dec 9, 2019
@imtbkcat imtbkcat mentioned this pull request Dec 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/LGT1 LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@imtbkcat @tiancaiamao @kennytm @jackysp @tsthght