Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser : add invalid auto increment and offset error. #707

Merged
merged 3 commits into from
Jan 2, 2020
Merged

parser : add invalid auto increment and offset error. #707

merged 3 commits into from
Jan 2, 2020

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Jan 2, 2020

What problem does this PR solve?

add errcode and errname for variable auto_increment_increment and auto_increment_offset.
Related TiDB PR #14301

What is changed and how it works?

Check List

Tests

  • Integration test

@AilinKid AilinKid requested a review from a team January 2, 2020 05:11
@ghost ghost requested review from tangenta and removed request for a team January 2, 2020 05:11
@AilinKid AilinKid requested a review from a team January 2, 2020 05:12
@ghost ghost removed their request for review January 2, 2020 05:12
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #707 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          38       38           
  Lines       14020    14020           
=======================================
  Hits        10933    10933           
  Misses       2435     2435           
  Partials      652      652

zimulala
zimulala reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bb7133
bb7133 reviewed Jan 2, 2020
View reviewed changes
mysql/errname.go Outdated Show resolved Hide resolved
kennytm
kennytm approved these changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta merged commit 18bb5e8 into pingcap:master Jan 2, 2020
AilinKid added a commit to AilinKid/parser that referenced this pull request Jan 8, 2020
@AilinKid
parser : add invalid auto increment and offset error (pingcap#707)
da73020
@AilinKid AilinKid mentioned this pull request Jan 8, 2020
Merged
AilinKid added a commit that referenced this pull request Jan 8, 2020
@AilinKid
parser : add invalid auto increment and offset error (#707) (#712)
73763c7
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@AilinKid @tangenta
parser : add invalid auto increment and offset error (pingcap#707)
36e4435
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@AilinKid @tangenta
parser : add invalid auto increment and offset error (pingcap#707)
d8b0a7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimulala zimulala zimulala left review comments

@bb7133 bb7133 bb7133 left review comments

@kennytm kennytm kennytm approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AilinKid @kennytm @bb7133 @zimulala @tangenta