Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint for broadcast join. #818

Merged
merged 20 commits into from
Jun 17, 2020
Merged

Add hint for broadcast join. #818

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
8b60f33
add hint for bc join
hanfei1991 Mar 7, 2020
fda93fd
refine
hanfei1991 Mar 7, 2020
4aebfbd
add hint for bc join
hanfei1991 Mar 7, 2020
cc2bee1
refine
hanfei1991 Mar 7, 2020
ee0ed27
refine
hanfei1991 Mar 7, 2020
f4bcaaa
refine
hanfei1991 Apr 20, 2020
3c139eb
refine again
hanfei1991 Apr 20, 2020
63e37f3
Merge branch 'master' into hanfei/bc_join
hanfei1991 Apr 20, 2020
f9d90d7
pass test
hanfei1991 Apr 20, 2020
be293a8
Merge branch 'master' of https://github.com/pingcap/parser into bc_join
windtalker May 6, 2020
497ab5e
Merge pull request #1 from windtalker/bc_join
hanfei1991 May 6, 2020
b02b990
fix compile error
windtalker May 6, 2020
dde82b0
Merge pull request #2 from windtalker/bc_join
hanfei1991 May 6, 2020
95b513a
Merge branch 'master' into hanfei/bc_join
hanfei1991 May 9, 2020
6a681e8
add prefer local
ichn-hu May 8, 2020
73e0eaa
use bcj_local
ichn-hu May 11, 2020
9942139
Merge pull request #3 from ichn-hu/bc-gr-hint
hanfei1991 May 11, 2020
980888f
Merge branch 'master' into hanfei/bc_join
hanfei1991 Jun 15, 2020
ac44a12
Merge branch 'master' into hanfei/bc_join
hanfei1991 Jun 17, 2020
444a49f
change bc_join to broadcast_join
hanfei1991 Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ast/misc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2597,7 +2597,7 @@ func (n *TableOptimizerHint) Restore(ctx *format.RestoreCtx) error {
ctx.WritePlainf("%d", n.HintData.(uint64))
case "nth_plan":
ctx.WritePlainf("%d", n.HintData.(int64))
case "tidb_hj", "tidb_smj", "tidb_inlj", "hash_join", "merge_join", "inl_join":
case "tidb_hj", "tidb_smj", "tidb_inlj", "hash_join", "merge_join", "inl_join", "bc_join", "bcj_local", "tidb_bcj":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: according to https://www.abbreviations.com/abbreviation/BROADCAST, seems BRDCST is a proper abbreviation for broadcast

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems brdcst is for media, I think it's quite verbose. Can we make it brief and easy to write ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you shorten it to "brdcst" i'd rather you just spell it out entirely

select /*+ broadcast_join(...) */ ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanfei1991 @lzmhhh123 PTAL the comment from @kennytm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support the bc_join as the abbreviation.

for i, table := range n.Tables {
if i != 0 {
ctx.WritePlain(", ")
Expand Down
2 changes: 2 additions & 0 deletions ast/misc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,9 @@ func (ts *testMiscSuite) TestTableOptimizerHintRestore(c *C) {
{"TIDB_HJ(t1,t2)", "TIDB_HJ(`t1`, `t2`)"},
{"TIDB_HJ(@sel1 t1,t2)", "TIDB_HJ(@`sel1` `t1`, `t2`)"},
{"TIDB_HJ(t1@sel1,t2@sel2)", "TIDB_HJ(`t1`@`sel1`, `t2`@`sel2`)"},
{"TIDB_BCJ(t1,t2)", "TIDB_BCJ(`t1`, `t2`)"},
{"MERGE_JOIN(t1,t2)", "MERGE_JOIN(`t1`, `t2`)"},
{"BC_JOIN(t1,t2)", "BC_JOIN(`t1`, `t2`)"},
{"INL_JOIN(t1,t2)", "INL_JOIN(`t1`, `t2`)"},
{"HASH_JOIN(t1,t2)", "HASH_JOIN(`t1`, `t2`)"},
{"MAX_EXECUTION_TIME(3000)", "MAX_EXECUTION_TIME(3000)"},
Expand Down
Loading