Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for IndexOption #88

Merged
merged 5 commits into from
Dec 21, 2018
Merged

parser: implement Restore for IndexOption #88

merged 5 commits into from
Dec 21, 2018

Conversation

feloxx
Copy link
Contributor

@feloxx feloxx commented Dec 20, 2018 •
edited
Loading

  1. implement Restore for IndexOption
  2. Add indexOption goyacc code
  3. Add indexOptionList goyacc code

Issue: pingcap/tidb#8532

@feloxx feloxx changed the title implement Restore for IndexOption parser: implement Restore for IndexOption Dec 20, 2018
kennytm
kennytm reviewed Dec 20, 2018
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Dec 20, 2018
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Dec 20, 2018
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

PTAL @leoppro

@kennytm kennytm added the status/LGT1 LGT1 label Dec 20, 2018
zier-one
zier-one reviewed Dec 21, 2018
View reviewed changes
parser.y Show resolved Hide resolved
@zier-one zier-one mentioned this pull request Dec 21, 2018
Closed
@zier-one zier-one mentioned this pull request Dec 21, 2018
Closed
@zier-one
Copy link
Contributor

LGTM

@zier-one zier-one merged commit c011c83 into pingcap:master Dec 21, 2018
@zier-one zier-one added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Dec 21, 2018
@zier-one zier-one self-assigned this Dec 21, 2018
@feloxx feloxx mentioned this pull request Dec 21, 2018
Merged
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@feloxx
parser: implement Restore for IndexOption (pingcap#88)
4caba24
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@feloxx
parser: implement Restore for IndexOption (pingcap#88)
66998f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@zier-one zier-one zier-one approved these changes

Assignees

@zier-one zier-one

Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feloxx @zier-one @kennytm