config: fix configs cannot set to zero values #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
/run-unit-test |
overvenus
approved these changes
Nov 22, 2018
Connor1996
pushed a commit
to Connor1996/pd
that referenced
this pull request
Dec 12, 2018
* config: fix configs cannot set to zero values Signed-off-by: disksing <i@disksing.com> * update default config to keep behaivour consistent Signed-off-by: disksing <i@disksing.com>
Connor1996
pushed a commit
to Connor1996/pd
that referenced
this pull request
Dec 12, 2018
* config: fix configs cannot set to zero values Signed-off-by: disksing <i@disksing.com> * update default config to keep behaivour consistent Signed-off-by: disksing <i@disksing.com>
disksing
pushed a commit
that referenced
this pull request
Dec 12, 2018
disksing
added
the
needs-cherry-pick-release-2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently we use
adjustXxxfunctions to set configurations to default values when they are zero values. It cannot distinguish between unset and the explicitly set to 0.Fix #1323
It should be merged after pingcap/tidb-ansible#605
What is changed and how it works?
For configurations that zero values are valid, only adjust to the default values when they are unset.
Check List
Tests
Code changes
Side effects
xxx = 0will be adjust to default value before, after this PR it will be 0.Related changes
tidb-ansiblerepository