[Cherry-pick] config: fix configs cannot set to zero values (#1334) #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connor1996
added
type/bug
* config: fix configs cannot set to zero values Signed-off-by: disksing <i@disksing.com> * update default config to keep behaivour consistent Signed-off-by: disksing <i@disksing.com>
Connor1996
force-pushed
the
release-2.1
branch
from
eb0195a to
b970fab
Compare
rleungx
added
cherry-pick
and removed
needs-cherry-pick-release-2.1
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
|
/run-unit-test |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1 |
|
/run-integration-common-test |
nolouch
approved these changes
Dec 12, 2018
disksing
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
cherry pick #1334