Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update etcd #1452

Merged
merged 3 commits into from
Mar 27, 2019
Merged

*: update etcd #1452

merged 3 commits into from
Mar 27, 2019

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Mar 8, 2019

What problem does this PR solve?

  • customized etcd logger
  • fix prevote bug
  • fast drop propose and read
  • fix the issue about renew a lease with long TTL.
  • Improve backend ( boltDB

What is changed and how it works?

update etcd.

Check List

Tests

  • Unit test
  • Integration test

@nolouch
Copy link
Contributor Author

nolouch commented Mar 20, 2019

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@zhouqiang-cl
Copy link
Contributor

/rebuild

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/rebuild

@zhouqiang-cl
Copy link
Contributor

/rebuild

@rleungx
Copy link
Member

rleungx commented Mar 27, 2019

@nolouch This PR could be merged now?

@nolouch nolouch removed the DNM label Mar 27, 2019
@nolouch
Copy link
Contributor Author

nolouch commented Mar 27, 2019

@rleungx Yes, this PR already running 5 days in schordinger and no problem now, I think we can merge it.

@nolouch nolouch requested a review from rleungx March 27, 2019 08:24
@codecov-io
Copy link

Codecov Report

Merging #1452 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
- Coverage   67.25%   67.22%   -0.03%     
==========================================
  Files         158      158              
  Lines       15383    15385       +2     
==========================================
- Hits        10346    10343       -3     
- Misses       4099     4106       +7     
+ Partials      938      936       -2
Impacted Files Coverage Δ
pkg/logutil/log.go 85.27% <ø> (ø) ⬆️
tests/cluster.go 83.33% <ø> (ø) ⬆️
server/join.go 55.4% <ø> (ø) ⬆️
server/tso.go 72.72% <ø> (ø) ⬆️
server/util.go 70.27% <ø> (ø) ⬆️
tools/pd-ctl/pdctl/command/global.go 41.66% <ø> (ø) ⬆️
server/etcd_kv.go 74.54% <ø> (+3.63%) ⬆️
server/api/utiletcdhttpapi.go 77.77% <ø> (ø) ⬆️
server/id.go 72.97% <ø> (ø) ⬆️
server/server.go 77.72% <ø> (-0.5%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5717017...eb22920. Read the comment docs.

@nolouch nolouch merged commit 329082d into tikv:master Mar 27, 2019
@nolouch nolouch deleted the update-etcd-2 branch March 27, 2019 08:42
This was referenced Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants