-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: remove useless log #4532
log: remove useless log #4532
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
553eb00
to
758238d
Compare
758238d
to
84c5389
Compare
Signed-off-by: nolouch <nolouch@gmail.com>
84c5389
to
9a1e048
Compare
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 319778d
|
/run-unit-test |
1 similar comment
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #4532 +/- ##
==========================================
+ Coverage 74.75% 74.96% +0.20%
==========================================
Files 265 265
Lines 27945 27844 -101
==========================================
- Hits 20891 20873 -18
+ Misses 5191 5111 -80
+ Partials 1863 1860 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
close #4531.
There are some logger exist in PD:
capnslog
,logrus
,zap
and so on.after #1452. etcd supports customize the logger, so we can remove the redundant loggers that remaining for compatibility purpose.
What is changed and how it works?
remove useless code
Check List
Tests
Release note