-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: fix the default value of log.format #4754
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #4754 +/- ##
==========================================
- Coverage 75.23% 75.12% -0.11%
==========================================
Files 287 287
Lines 28161 28163 +2
==========================================
- Hits 21186 21158 -28
- Misses 5108 5134 +26
- Partials 1867 1871 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: a5d07e5
|
In response to a cherrypick label: new pull request created: #4755. |
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Issue Number: Close #4753
#4532 removed the code to initialize the default value of
log.format
. This PR adds it back.What is changed and how it works?
Check List
Tests
Release note