Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: fix the default value of log.format #4754

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Mar 21, 2022

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: Close #4753

#4532 removed the code to initialize the default value of log.format. This PR adds it back.

What is changed and how it works?

config: fix the default value of log.format

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 21, 2022
@JmPotato JmPotato requested a review from rleungx March 21, 2022 03:41
@ti-chi-bot ti-chi-bot requested a review from Yisaer March 21, 2022 03:41
@JmPotato JmPotato added require-LGT1 Indicates that the PR requires an LGTM. needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. labels Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #4754 (a5d07e5) into master (d58d7c9) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4754      +/-   ##
==========================================
- Coverage   75.23%   75.12%   -0.11%     
==========================================
  Files         287      287              
  Lines       28161    28163       +2     
==========================================
- Hits        21186    21158      -28     
- Misses       5108     5134      +26     
- Partials     1867     1871       +4     
Flag Coverage Δ
unittests 75.12% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.03% <100.00%> (+0.09%) ⬆️
server/election/leadership.go 73.19% <0.00%> (-7.22%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
server/tso/allocator_manager.go 63.45% <0.00%> (-3.93%) ⬇️
server/tso/tso.go 66.85% <0.00%> (-2.86%) ⬇️
pkg/etcdutil/etcdutil.go 85.88% <0.00%> (-2.36%) ⬇️
server/member/member.go 63.10% <0.00%> (-1.61%) ⬇️
server/region_syncer/client.go 83.59% <0.00%> (-1.57%) ⬇️
server/schedule/operator_controller.go 84.44% <0.00%> (-1.22%) ⬇️
server/storage/hot_region_storage.go 78.73% <0.00%> (-1.15%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d58d7c9...a5d07e5. Read the comment docs.

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 21, 2022
@nolouch
Copy link
Contributor

nolouch commented Mar 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a5d07e5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 21, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4755.

@JmPotato JmPotato deleted the fix_log_format_default_val branch March 21, 2022 03:59
ti-chi-bot added a commit that referenced this pull request Mar 22, 2022
close #4753, ref #4754

config: fix the default value of log.format

Signed-off-by: JmPotato <ghzpotato@gmail.com>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6.0.0, default value of log.format change to ""
4 participants