*: add some log for debug (#499)

* *: add some log for debug * improve log * fix
pingcap · Nov 11, 2024 · c97a983 · c97a983
1 parent 20630c9
commit c97a983
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/logservice/eventstore/event_store.go b/logservice/eventstore/event_store.go
@@ -441,6 +441,11 @@ func (e *eventStore) RegisterDispatcher(
 					subscriptionStat.ids[dispatcherID] = true
 					candidateIDs[dispatcherID] = true
 					e.dispatcherStates.Unlock()
+					log.Info("reuse existing subscription",
+						zap.Any("dispatcherID", dispatcherID),
+						zap.Uint64("subID", uint64(stat.subID)),
+						zap.Uint64("checkpointTs", subscriptionStat.checkpointTs),
+						zap.Uint64("startTs", startTs))
 					return nil
 				}
 			}
@@ -562,6 +567,11 @@ func (e *eventStore) UpdateDispatcherSendTs(
 				subscriptionStat.checkpointTs,
 				newCheckpointTs,
 			)
+			log.Debug("update checkpoint ts",
+				zap.Any("dispatcherID", dispatcherID),
+				zap.Uint64("subID", uint64(stat.subID)),
+				zap.Uint64("newCheckpointTs", newCheckpointTs),
+				zap.Uint64("oldCheckpointTs", subscriptionStat.checkpointTs))
 			subscriptionStat.checkpointTs = newCheckpointTs
 		}
 	}

diff --git a/logservice/schemastore/disk_format.go b/logservice/schemastore/disk_format.go
@@ -350,7 +350,9 @@ func readPersistedDDLEvent(snap *pebble.Snapshot, version uint64) PersistedDDLEv
 	}
 	ddlValue, closer, err := snap.Get(ddlKey)
 	if err != nil {
-		log.Fatal("get ddl job failed", zap.Error(err))
+		log.Fatal("get ddl job failed",
+			zap.Uint64("version", version),
+			zap.Error(err))
 	}
 	defer closer.Close()
 	return unmarshalPersistedDDLEvent(ddlValue)