-
Notifications
You must be signed in to change notification settings - Fork 274
Conversation
rolling_update.yml
Outdated
tags: | ||
- pd | ||
tasks: | ||
- name: Get pd leader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rolling_update.yml
Outdated
register: pd_status | ||
- name: Failed when one node of pd is unhealthy | ||
fail: | ||
msg: "Some pd node is unhealth" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax error
groups: pd_servers_followers | ||
pd_client_port: "{{ pd_client_port }}" | ||
deploy_dir: "{{ deploy_dir }}" | ||
pd_peer_port: "{{ pd_peer_port }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that pd_servers_followers groups don't have group variables in
https://github.com/pingcap/tidb-ansible/blob/master/group_vars/pd_servers.yml and other customized host variables.
@@ -54,8 +54,101 @@ | |||
- current_version.stdout_lines[0].replace(' ','').split(':')[1] < "v2.0.1" | |||
- tidb_version >= "v2.1.0" or tidb_version == "latest" | |||
|
|||
- hosts: pd_servers | |||
any_errors_fatal: true | |||
serial: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need serial: 1
?
|
||
- hosts: pd_servers | ||
any_errors_fatal: true | ||
serial: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Divide the pd node into two groups(leader and follower), upgrade the follower first, and finally upgrade the leader.
@LinuxGit @superlzs0476 PTAL