Use histogram instead

pingcap · May 20, 2019 · 7ec96ef · 7ec96ef
1 parent 7141468
commit 7ec96ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/drainer/metrics.go b/drainer/metrics.go
@@ -69,12 +69,13 @@ var (
 			Help:      "save checkpoint tso of drainer.",
 		})
 
-	checkpointDelayGauge = prometheus.NewGauge(
-		prometheus.GaugeOpts{
+	checkpointDelayHistogram = prometheus.NewHistogram(
+		prometheus.HistogramOpts{
 			Namespace: "binlog",
 			Subsystem: "drainer",
 			Name:      "checkpoint_delay_seconds",
 			Help:      "How much the downstream checkpoint lag behind",
+			Buckets:   prometheus.ExponentialBuckets(0.00005, 2, 18),
 		})
 
 	executeHistogram = prometheus.NewHistogram(
@@ -131,7 +132,7 @@ func init() {
 	registry.MustRegister(ddlJobsCounter)
 	registry.MustRegister(errorCount)
 	registry.MustRegister(checkpointTSOGauge)
-	registry.MustRegister(checkpointDelayGauge)
+	registry.MustRegister(checkpointDelayHistogram)
 	registry.MustRegister(eventCounter)
 	registry.MustRegister(executeHistogram)
 	registry.MustRegister(binlogReachDurationHistogram)

diff --git a/drainer/syncer.go b/drainer/syncer.go
@@ -222,7 +222,7 @@ func (s *Syncer) handleSuccess(fakeBinlog chan *pb.Binlog, lastTS *int64) {
 				eventCounter.WithLabelValues("savepoint").Add(1)
 			}
 			delay := oracle.GetPhysical(time.Now()) - oracle.ExtractPhysical(uint64(ts))
-			checkpointDelayGauge.Set(float64(delay) / 1e3)
+			checkpointDelayHistogram.Observe(float64(delay) / 1e3)
 		}
 	}