fix deadlock while drainer.Syncer panic (#807)

pingcap · Nov 14, 2019 · bb0f25a · bb0f25a
1 parent d84ef50
commit bb0f25a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drainer/syncer.go b/drainer/syncer.go
@@ -258,6 +258,8 @@ func (s *Syncer) savePoint(ts, slaveTS int64) {
 }
 
 func (s *Syncer) run() error {
+ defer close(s.closed)
+
  wait := make(chan struct{})
 
  fakeBinlogCh := make(chan *pb.Binlog, 1024)
@@ -422,8 +424,6 @@ ForLoop:
  panic("Waiting too long for `Syncer.run` to quit.")
  }
 
- close(s.closed)
-
  // return the origin error if has, or the close error
  if err != nil {
  return err