-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drainer: can't send request correctly to pump when set compressor=gzip
#1152
Comments
Guess it's because the pump doesn't set a decompressor. |
having similar issue on v5.2.2 after changing drainer's
|
After a careful check this problem is introduced in #1039 In this PR we set pump/drainer's max grpc message size to maxGrpcMsgSize = int(^uint(0) >> 1) However, when grpc decompresses messages, it will left a few buffer for this, which overflows the int64: |
Bug Report
Please answer these questions before submitting your issue. Thanks!
What did you do?
If possible, provide a recipe for reproducing the error.
Start a TiDB cluster and set
compressor=grip
in drainer's config.What did you expect to see?
Drainer can replicate data correctly.
What did you see instead?
Drainer fails to pull binlogs from pump. Pump can't read request correctly:
pump.log
:(run
drainer -V
in terminal to get drainer's version)v5.2.3
The text was updated successfully, but these errors were encountered: