Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer: make drainer compatiable with batch create tables job #1114

Merged
merged 11 commits into from
Mar 9, 2022

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1113

What is changed and how it works?

Support handling table schema info according to BR batch creates tables job.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Use BR to batch create tables on upstream and update the restored tables. And in the manual test drainer can successfully sync the data for the specified tables.

Code changes

  • Has exported function/method change

Side effects

  • Possible performance regression

Related changes

  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fengou1
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/M and removed size/L labels Dec 31, 2021
@lichunzhu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@lichunzhu
Copy link
Contributor Author

/run-all-tests

@glorv glorv added the needs-cherry-pick-release-5.4 Type: Need cherry pick to release-5.4 label Jan 11, 2022
@lichunzhu
Copy link
Contributor Author

/run-all-tests
@lance6716 PTAL

Copy link

@fengou1 fengou1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the previous local test show it works well when BR restore with binlog enabled cluster

@lichunzhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4cd50d

@ti-chi-bot ti-chi-bot merged commit 0f865d8 into pingcap:master Mar 9, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.4: error checking out 5.4: exit status 1. output: error: pathspec '5.4' did not match any file(s) known to git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make drainer support br batch create tables ddl job
4 participants