-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pump/* add a api to get binlog by ts #449
Conversation
pump/server.go
Outdated
tsStr := mux.Vars(r)["ts"] | ||
ts, err := strconv.ParseInt(tsStr, 10, 64) | ||
if err != nil { | ||
w.Write([]byte("wrong ts param")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid parameter ts
@GregoryIan PTAL |
LGTM |
@WangXiangUSTC PTAL |
I think it's hard to know the commit ts when we debug, can we select by range? |
ts is a key point, we just want to dump the specified ts binlog. |
I mean we may can't get the ts information when we debug, need get binlog by range. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* pump/* add a api to get binlog by ts
What problem does this PR solve?
add a api to get binlog by ts for debug
issue: https://internal.pingcap.net/jira/browse/TOOL-794
What is changed and how it works?
/debug/binlog/ to display the binlog info
Check List
Tests
query the api by some ts