switch juju/errors to pingcap/error #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run: find . | grep "\.go$" | grep -v "vendor" | xargs \ gsed -i 's/github.com\/juju\/errors/github.com\/pingcap\/errors/g' $* and update github.com/zanmato1984/clickhouse
|
/run-all-tests |
|
LGTM |
|
whether needing to adjust the order of imports? |
done, need to fix CI.. |
csuzhangxc
approved these changes
Feb 15, 2019
sure, can update pingcap/error, but we should avoid use this later |
|
/run-all-tests |
july2993
added a commit
that referenced
this pull request
Feb 27, 2019
* switch juju/errors to pingcap/error run: find . | grep "\.go$" | grep -v "vendor" | xargs \ gsed -i 's/github.com\/juju\/errors/github.com\/pingcap\/errors/g' $* and update github.com/zanmato1984/clickhouse * go fmt all files
july2993
added a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
switch juju/errors to pingcap/error
What is changed and how it works?
run:
find . | grep ".go$" | grep -v "vendor" | xargs
gsed -i 's/github.com/juju/errors/github.com/pingcap/errors/g' $*
and update github.com/zanmato1984/clickhouse
fix panic in diff/diff
pingcap/error.IsNotFound(err) err must not be nil
but for juju it can be nil
see https://github.com/pingcap/errors/pull/11/files
and check other code
Check List
Tests
Code changes
Side effects
Related changes