-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine gc strategy of pump (#646) #663
Conversation
/run-all-tests |
/run-all-tests |
/run-integration-tests |
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@july2993 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
most users forget to mark drainer offline using
binlogctl
after they stop drainer, It would block gc of pump, and then the pump will easily fill up the disk capacity because there are too many binlogs.Regardless of ease of use or design, this design is unreasonable. There are two main reasons:
What is changed and how it works?
Check List
Tests
Related changes
tidb-ansible
repository