Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drainer/: Add ignore-txn-commit-ts to skip some txn (#685) #697

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Aug 1, 2019

What problem does this PR solve?

add ignore-txn-commit-ts to skip some txn.
use case: for some incompatible DDL, user may handle it manaually and want to skip this binlog, currentlly, usert can only change the checkpoint to skip this, the process is tedious and prone to error.

What is changed and how it works?

cherry-pick #685

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@july2993
Copy link
Contributor Author

july2993 commented Aug 1, 2019

/run-all-tests

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu
Copy link
Contributor

LGTM

@july2993 july2993 merged commit be03106 into release-2.1 Aug 5, 2019
@july2993 july2993 deleted the hjh/pick_txn branch August 5, 2019 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants