Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update parser in go.mode & go.sum to tidb release 2.1 #705

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

lichunzhu
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

update parser in go.mode & go.sum to synchronize binlog with tidb.

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

Related changes

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor Author

/run-all-tests

@july2993
Copy link
Contributor

july2993 commented Aug 9, 2019

can you help test this paser version can parse the pre_split ddl to make sure it works

Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor

july2993 commented Aug 9, 2019

@csuzhangxc @suzaku PTAL

Copy link
Contributor

@suzaku suzaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993 july2993 merged commit 3bd1e5c into pingcap:release-2.1 Aug 9, 2019
@lichunzhu
Copy link
Contributor Author

can you help test this paser version can parse the pre_split ddl to make sure it works

@july2993 I will add some tests in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants