Change default cache count from 65536 to 512(#721) #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests tidb=release-2.1 tikv=release-2.1 pd=release-2.1 |
|
do not merge first, need more test, I will fire a relate pr. |
|
this var will affect another var...and make make nearly can't write to the downstream concurrently. |
OK. I find that it will affect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry pick of #721
Current default cache count is too big which can easily cause OOM of drainer.
What is changed and how it works?
The default size is changed from 65536 to 512.
Check List
Tests
Code changes
Side effects
Related changes