add timeout for gs.GracefulStop #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
suzaku
reviewed
Nov 20, 2019
pkg/util/util.go
Outdated
| exited := make(chan struct{}) | ||
| go func() { | ||
| defer func() { | ||
| log.Info("goroutine exit bt itself (with GoAndAbortGoroutine help)", fName) |
pkg/util/util.go
Outdated
| }() | ||
|
|
||
| select { | ||
| case <-time.After((timeout)): |
There was a problem hiding this comment.
Suggested change
| case <-time.After((timeout)): | |
| case <-time.After(timeout): |
pkg/util/util.go
Outdated
| @@ -280,3 +280,22 @@ func AdjustDuration(v *time.Duration, defValue time.Duration) { | |||
| *v = defValue | |||
| } | |||
| } | |||
|
|
|||
| // GoAndAbortGoroutine creates a goroutine to run fn, and then gives up waiting for the goroutine to exit When it timeouts | |||
| func GoAndAbortGoroutine(name string, fn func(), timeout time.Duration) { | |||
There was a problem hiding this comment.
Maybe WaitUntilTimeout is a better name?
|
/run-all-tests |
|
/run-integration-tests tidb=release-3.0 |
|
cherry pick to release-3.0 in PR #817 |
|
cherry pick to release-2.1 failed |
IANTHEREAL
pushed a commit
that referenced
this pull request
Nov 20, 2019
IANTHEREAL
added
needs-cherry-pick-release-2.1
needs-cherry-pick-release-3.1
and removed
needs-cherry-pick-release-2.1
labels
|
cherry pick to release-3.1 in PR #824 |
IANTHEREAL
pushed a commit
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
sometime pump would block at
gs.GracefulStopwhen it exits, we still don't know the specific reason, but we don't need to wait for GRPC service exited, it's safe.What is changed and how it works?
add a timeout mechanism to give up waiting for the goroutine to exit
Check List
Tests