Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: bugfix, handle "missing column" when a column is getting dro… #844

Merged
merged 5 commits into from
Dec 23, 2019
Merged

drainer: bugfix, handle "missing column" when a column is getting dro… #844

merged 5 commits into from
Dec 23, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Dec 10, 2019

…pped

What problem does this PR solve?

Cherry-pick #803

@suzaku
Copy link
Contributor Author

suzaku commented Dec 10, 2019

/run-all-tests

@july2993
Copy link
Contributor

pls fix ci

@suzaku
Copy link
Contributor Author

suzaku commented Dec 16, 2019

@july2993 What's the default version of TiDB used when running integration tests for this branch?

@july2993
Copy link
Contributor

@july2993 What's the default version of TiDB used when running integration tests for this branch?

latest commit of branch release-2.1

@IANTHEREAL
Copy link
Collaborator

what's problem with CI?

@suzaku
Copy link
Contributor Author

suzaku commented Dec 17, 2019

@GregoryIan It seems like the bug is not fixed by this PR. So the new integration tests failed.

@suzaku
Copy link
Contributor Author

suzaku commented Dec 17, 2019

@july2993 What's the default version of TiDB used when running integration tests for this branch?

latest commit of branch release-2.1

We may need to wait until the corresponding check-pick on TiDB is merged.

@zier-one zier-one mentioned this pull request Dec 20, 2019
Merged
@suzaku
Copy link
Contributor Author

suzaku commented Dec 20, 2019

/run-integration-tests

@suzaku
Copy link
Contributor Author

suzaku commented Dec 20, 2019

/run-integration-tests tidb=release-2.1

july2993
july2993 reviewed Dec 20, 2019
View reviewed changes
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suzaku
Copy link
Contributor Author

suzaku commented Dec 20, 2019

/run-all-tests tidb=release-2.1

@suzaku
Copy link
Contributor Author

suzaku commented Dec 20, 2019

/run-unit-tests

@suzaku
Copy link
Contributor Author

suzaku commented Dec 20, 2019

/run-all-tests tidb=release-2.1

@zier-one
Copy link
Contributor

we should handle DdlSchemaState at storage.go#L986

@zier-one
Copy link
Contributor

rest LGTM

@suzaku
Copy link
Contributor Author

suzaku commented Dec 21, 2019

we should handle DdlSchemaState at storage.go#L986

@suzaku suzaku closed this Dec 21, 2019
@suzaku suzaku reopened this Dec 21, 2019
WangXiangUSTC
WangXiangUSTC previously approved these changes Dec 21, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

LGTM

ignore it

@suzaku
Copy link
Contributor Author

suzaku commented Dec 23, 2019

/run-all-tests tidb=release-2.1

@zier-one
Copy link
Contributor

LGTM

@suzaku suzaku merged commit 233a351 into pingcap:release-2.1 Dec 23, 2019
@suzaku suzaku deleted the pick-drop-col-2.1 branch December 23, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@july2993 july2993 july2993 left review comments

@zier-one zier-one zier-one approved these changes

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

Assignees
No one assigned
Labels
status/LGT2 type/cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suzaku @july2993 @IANTHEREAL @zier-one @WangXiangUSTC