binlog loop back sync #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.surport ddl one-way synchronization 2.surport dml Mutual synchronization 3.surport cluster A Mutual synchronization B,cluster B Mutual synchronization C,cluster C binlog can sync to A or not sync to A by set channel_id
modify mark table name
1.add create mark table logic
1.fix bug
|
/run-all-tests don't recreate pr so we can keep and trace the review comments. |
|
/run-all-tests |
july2993
reviewed
Jan 10, 2020
july2993
reviewed
Jan 12, 2020
july2993
reviewed
Jan 12, 2020
|
Please resolve the conflict. |
suzaku
reviewed
Jan 13, 2020
Merge remote-tracking branch 'upstream/master' # Conflicts: # pkg/loader/load.go
|
fix code format and fix some bugs；Resolving conflicts |
|
/run-all-tests |
july2993
reviewed
Jan 13, 2020
2.rename stream_info to channel_info 3.delete updateMark function status param 4.adjust column hard code to const reference
|
1.adjust explanatory note for sync-ddl,loopback-control and channel-id |
|
/run-all-tests |
july2993
reviewed
Jan 14, 2020
july2993
reviewed
Jan 14, 2020
|
1.adjust TestUpdateMarkSQL function logic |
|
/run-all-tests |
july2993
reviewed
Jan 14, 2020
|
remove comment line |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
july2993
pushed a commit
to july2993/tidb-binlog
that referenced
this pull request
Jan 15, 2020
In the AA dual activity scenario, there is data write (DML) on both sides. The data of tidb cluster on both sides needs to be synchronized with each other，but avoid loopback synchronization，and ddl is only writed one side. add three variables in drainer.toml as identification to confirm need sync ddl or not and need set sync mark identification or not and sync identification id to Avoid loopback synchronization add configuration item loopback-control (true/false) set mark table identification or not and filter txn by mark table ddl-sync (true/false) sync ddl to downstream DB or not channel-id (integer) sync identification id，avoid loopback synchronization Co-authored-by: Nihao123451 <37206498+Nihao123451@users.noreply.github.com>
Merged
july2993
added a commit
that referenced
this pull request
Jan 15, 2020
* Add sync mode config (#867) allow when the column number of downstream table mismatch with current schema. For the case bidirectional replication, we will execute the DDL at one side, for add or drop column the column number will mismatch. cluster A <-> cluster B drop column of table t at cluster A some DML of table t at cluster B will miss the column dropped compared to cluster A * binlog loop back sync (#879) In the AA dual activity scenario, there is data write (DML) on both sides. The data of tidb cluster on both sides needs to be synchronized with each other，but avoid loopback synchronization，and ddl is only writed one side. add three variables in drainer.toml as identification to confirm need sync ddl or not and need set sync mark identification or not and sync identification id to Avoid loopback synchronization add configuration item loopback-control (true/false) set mark table identification or not and filter txn by mark table ddl-sync (true/false) sync ddl to downstream DB or not channel-id (integer) sync identification id，avoid loopback synchronization Co-authored-by: Nihao123451 <37206498+Nihao123451@users.noreply.github.com> Co-authored-by: freemindLi <59459626+freemindLi@users.noreply.github.com> Co-authored-by: Nihao123451 <37206498+Nihao123451@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recreate of #864
What problem does this PR solve?
In the AA dual activity scenario, there is data write (DML) on both sides. The data of tidb cluster on both sides needs to be synchronized with each other，but avoid loopback synchronization，and ddl is only writed one side.
What is changed and how it works?
add three variables in drainer.toml as identification to confirm need sync ddl or not and need set sync mark identification or not and sync identification id to Avoid loopback synchronization
add configuration item
loopback-control (true/false) set mark table identification or not and filter txn by mark table
ddl-sync (true/false) sync ddl to downstream DB or not
channel-id (integer) sync identification id，avoid loopback synchronization
Check List
Tests
will add in Add test case loop for mark status #882
Related changes