Handle create/drop sequence job type #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. handle create/drop sequence job type 2. ref pingcap/tidb#14954 TiDB will write a fake ddl binlog like: select setval(`seq`.`sequence_name`, 1000) when the value of sequence is changed for replicate the value of the sequence. we CAN NOT query the job from the tikv according the job id. just skip this kind of binlog now.
|
/run-integration-tests |
|
@GregoryIan PTAL |
|
This implementation of the DDL really irks me, completely out of spec, a DDL, but donn't have DDL job. This implementation forces the binlog or CDC to have special dispersed logic to filter this DDL @siddontang |
IANTHEREAL
approved these changes
Apr 24, 2020
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
handle create/drop sequence job type
filter out the special DDL binlog for replicate the value of sequence now.
before this PR: will abort the replicate once create sequence at upstream.
after this PR: the create/drop sequence dll can be replicated, but the value of the sequence WILL NOT be replicated to downstream.
What is changed and how it works?
TiDB will write a fake ddl binlog like: select setval(
seq.sequence_name, 1000)when the value of sequence is changed for replicate the value of the sequence.
we CAN NOT query the job from the tikv according the job id.
just skip this kind of binlog now.
Check List
Tests
Code changes
Side effects
Related changes