Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi rows of same table split into multi table in the downstream format #958

Merged
merged 4 commits into from
May 29, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Apr 24, 2020

What problem does this PR solve?

fix #932

What is changed and how it works?

put the mutations of the same table in one Table struct

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

Release note

  • Fix multi rows of the same table split into multi-table structure in the downstream format

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@july2993
Copy link
Contributor Author

july2993 commented May 6, 2020

/run-all-tests
@GregoryIan PTAL

@sre-bot
Copy link

sre-bot commented May 12, 2020

@july2993
Copy link
Contributor Author

/rebuild

@sre-bot
Copy link

sre-bot commented May 12, 2020

@july2993
Copy link
Contributor Author

/rebuild

@july2993
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-bot
Copy link

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot
Copy link

sre-bot commented May 29, 2020

@july2993 merge failed.

@july2993
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link

sre-bot commented May 29, 2020

cherry pick to release-3.0 in PR #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drainer translate binlog for kafka one table only have one mutation
4 participants